Skip to content

missing DIP_EXPORT for Pixel operator != #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisluengo merged 2 commits into from
Aug 30, 2025
Merged

missing DIP_EXPORT for Pixel operator != #209

crisluengo merged 2 commits into from
Aug 30, 2025

Conversation

@VisualFox
Copy link
Contributor

@VisualFox VisualFox commented Aug 30, 2025 •
edited
Loading

attempt to fix #208

//doesn't compile missing DIP_EXPORT for Image::Pixel != Image::Pixel in include/diplib/library/image_views.h at line 787
if ( kernelImageA.At(0) != kernelImageB.At(0) ) {
    std::cout << "also expected" << std::endl;
}

crisluengo
crisluengo reviewed Aug 30, 2025
View reviewed changes
include/diplib/library/image_views.h Outdated

/// \brief Comparison operator, equivalent to `!(lhs==rhs)`.
/// \relates dip::Image::Pixel
DIP_EXPORT bool operator!=( Image::Pixel const& lhs, Image::Pixel const& rhs );
Copy link
Member

@crisluengo crisluengo Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A trivial function like this can be defined inline:

inline bool operator!=( Image::Pixel const& lhs, Image::Pixel const& rhs ) { return !( lhs == rhs ); }

Copy link
Contributor Author

@VisualFox VisualFox Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just implement it in image_view.h in this case? Seem a bit silly to put that one in pixel.cpp

Copy link
Member

@crisluengo crisluengo Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was the intention. That allows the optimizing compiler to skip one function call.

Copy link
Contributor Author

@VisualFox VisualFox Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@crisluengo crisluengo merged commit d5e2be4 into DIPlib:master Aug 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crisluengo crisluengo crisluengo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing DIP_EXPORT for Image::Pixel != Image::Pixel (image_views.h)

2 participants

@VisualFox @crisluengo